feat: add fixture for components placed using calculating packing not rotated properly#2062
Merged
rushabhcodes merged 1 commit intotscircuit:mainfrom Mar 20, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a new Bun test fixture to validate 3D model orientation in circuit rendering by snapshotting a board populated with multiple resistors.
Changes:
- Added
should orient all models correctlytest that creates a board with nine 0402 resistors. - Captures a simple 3D snapshot for regression coverage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rushabhcodes
changed the title
MustafaMulla29
approved these changes
Mar 20, 2026
Contributor
|
Thank you for your contribution! 🎉 PR Rating: ⭐⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new fixture
R9here is not rotated